drivers: i2s_mcux_sai: Cleanup #75797
Conversation
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
decsny
force-pushed
the
fix/clean_i2s_driver
branch
from
641cf45 to
f90bd10
Compare
|
rebased, updated the PR, removed some of the changes. The changes in the current state of the PR reduce the size of the driver .text section size by almost 3%. |
zephyrbot
requested review from
anangl,
danieldegrasse,
dbaluta,
manuargue and
MarkWangChinese
decsny
added
DNM
|
@decsny this needs a rebase |
Put DT_DRV_COMPAT at top of file by custom Consolidate logging macros Clean up checks and use build assert Remove header file which was not necessary Remove unnecessary forward declarations Fix the type of the stream state to be more precise, it is used as the enum i2s_state type. This requires handling all the enum cases in switch statements Signed-off-by: Declan Snyder <[email protected]>
There's no need to put an if before i2s_purge_stream_buffers, because this is handled already by the boolean values entered to the function Also remove the inline of the function, which allowed the compiler to make optimizations and save some bytes. Signed-off-by: Declan Snyder <[email protected]>
Simplify some code by using the sai_sync_mode_t type directly instead of converting from boolean Signed-off-by: Declan Snyder <[email protected]>
move copy pasted code into common spot for when there is an invalid configuration passed to the config function Signed-off-by: Declan Snyder <[email protected]>
Change this code about the frame and bit clock to be more readable Signed-off-by: Declan Snyder <[email protected]>
Creating this local variable saves some text space in ROM Signed-off-by: Declan Snyder <[email protected]>
The dma callback functions were written in a very confusing way, clean them up, and this change also saves some bytes of ROM. Signed-off-by: Declan Snyder <[email protected]>
decsny
dismissed stale reviews from bjarki-andreasen and danieldegrasse
via
956dad7
decsny
force-pushed
the
fix/clean_i2s_driver
branch
from
f90bd10 to
956dad7
Compare
|
removed the commit refactoring the token names, it was not necessary and too many conflicts, I didn't care also tested on RT1060 EVKB and passed i2s_speed test |
While debugging the i2s sai driver, we discovered that the driver is very hard to follow and there is a lot of redundant code. Clean up the code to be more readable and understandable. All the logic should be the same.