boards: others: add support for the CANbardo USB to CAN adapter board #83570
Conversation
henrikbrixandersen
force-pushed
the
canbardo
branch
from
a29fbdd to
246f58d
Compare
boards/others/canbardo/doc/index.rst
Outdated
| Supported Features | ||
| ================== | ||
|
|
||
| The ``canboardo`` board configuration supports the following hardware features: |
There was a problem hiding this comment.
| The ``canboardo`` board configuration supports the following hardware features: | |
| The ``canboardo`` board supports the following hardware features: |
There was a problem hiding this comment.
Thank you for reviewing. I've changed the text accordingly.
henrikbrixandersen
force-pushed
the
canbardo
branch
2 times, most recently
from
5a4dc61 to
f1f5b54
Compare
| transceiver0: can-phy0 { | ||
| compatible = "microchip,mcp2558fd", "can-transceiver-gpio"; | ||
| enable-gpios = <&piod 26 GPIO_ACTIVE_LOW>; | ||
| max-bitrate = <8000000>; |
There was a problem hiding this comment.
may not be a bad idea to switch these to use DT_FREQ_M
There was a problem hiding this comment.
I have refrained from doing that in the past since it reads wrong. A bitrate is not a frequency as in cycles per second, but rather measured as bit per second.
There was a problem hiding this comment.
mmh ok... should there be some aliases for the macros? DT_BITRATE_M? the issue is obviously the number readability on the file though if you have the wrong one here you'd find out pretty quickly
There was a problem hiding this comment.
Could be an enhancement, sure.
henrikbrixandersen
force-pushed
the
canbardo
branch
from
f1f5b54 to
7739163
Compare
boards/others/canbardo/doc/index.rst
Outdated
| Supported Features | ||
| ================== | ||
|
|
||
| The ``canboardo`` board supports the following hardware features: |
There was a problem hiding this comment.
| The ``canboardo`` board supports the following hardware features: | |
| The ``canbardo`` board supports the following hardware features: |
There was a problem hiding this comment.
Gah, thanks! If I had a dime for every time I had writting "CANboardo bard" during the design of this board, I'd be rich.
Fixed.
There was a problem hiding this comment.
Ya I was gonna say I'm sure there is some kind of pun that I'm missing that led to this board being named the way it is, but it certainly is very typo/error-prone :)
Add support for the open hardware CANbardo Universal Serial Bus (USB) to Controller Area Network (CAN) adapter board. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
canbardo
branch
from
7739163 to
093f3b0
Compare
Add support for the open hardware CANbardo Universal Serial Bus (USB) to Controller Area Network (CAN) adapter board.
Documentation preview: https://builds.zephyrproject.io/zephyr/pr/83570/docs/boards/others/canbardo/doc/index.html
Note:This PR depends on #83547 being merged first (as it contains the same refactoring commit in order to add the needed SoC flash density variant).