Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: allow mounting filesystems at / #83672

Merged

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Jan 8, 2025

Previously, filesystems could not be mounted at '/' because mount points were restricted to being at least 2 characters.

Since '/' corresponds to the standard POSIX root filesystem location, reduce the minimum length of a mount point to 1 character.

With that, we can mount a POSIX root filesystem.

Forked from #83368

Previously, filesystems could not be mounted at '/' because
mount points were restricted to being at least 2 characters.

Since '/' corresponds to the standard POSIX root filesystem
location, reduce the minimum length of a mount point to
1 character.

With that, we can mount a POSIX root filesystem.

Signed-off-by: Chris Friedt <[email protected]>
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the change, just make sure there is simple test case covering mounting file system at the top level.

@cfriedt
Copy link
Member Author

cfriedt commented Jan 8, 2025

@de-nordic - absolutely, I forgot to link to the original PR, but tests are included in #83368

Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@de-nordic de-nordic added this to the v4.1.0 milestone Jan 8, 2025
@kartben kartben merged commit ec7d272 into zephyrproject-rtos:main Jan 10, 2025
30 checks passed
@cfriedt cfriedt deleted the allow-mounting-filesystems-at-root branch January 10, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: File System size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants