fixed orbitals=slice(1, None) arguments

It was returning geometr.na, while it should return geometry.no. This commit fixes this. Signed-off-by: Nick Papior <[email protected]>
zerothi · Dec 5, 2024 · 1e6ae8e · 1e6ae8e
1 parent 50ed40b
commit 1e6ae8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,8 @@ we hit release version 1.0.0.
 
 ### Fixed
 - `projection` arguments of several functions has been streamlined
+- `orbitals` arguments with slices without ends returned up to `geometry.na`,
+  now it correctly returns up to the maximum number of orbitals.
 
 ### Changed
 - internal Cython code for performance improvements.

diff --git a/src/sisl/_core/geometry.py b/src/sisl/_core/geometry.py
@@ -471,7 +471,7 @@ def _(self, orbitals: slice) -> ndarray:
         if start is None:
             start = 0
         if stop is None:
-            stop = self.na
+            stop = self.no
         if step is None:
             step = 1
         return np.arange(start, stop, step)