Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included missing notebook in the viz docs #630

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Oct 23, 2023

I don't know why, but there was a notebook that was not included in the .rst file (probably I forgot to include it).

@zerothi zerothi merged commit 9c9c61f into zerothi:main Oct 23, 2023
4 checks passed
@pfebrer
Copy link
Contributor Author

pfebrer commented Oct 23, 2023

Thanks! Could you refresh the documentation? I'm writing a message on discord to advertise the new sisl.viz :)

@zerothi
Copy link
Owner

zerothi commented Oct 23, 2023

Is it important to get out now? It could be great to get #629 in as well? Shouldn't take too much

@pfebrer
Copy link
Contributor Author

pfebrer commented Oct 23, 2023

Hmm ok, I'll just save the message

@zerothi
Copy link
Owner

zerothi commented Oct 23, 2023

I am quite worried about my limits on the CI's, not infrequently I get emails on having runned too much :)
That is why I am trying to limit unnecessary runs. Hope you understand!
(you can print it here for safe keeping? )

@pfebrer
Copy link
Contributor Author

pfebrer commented Oct 23, 2023

In the case of documentation I think it would be worth to have some caching, specially of the executed notebooks. (the hardest point would be to keep track of which parts of sisl the notebook depends on)

@pfebrer pfebrer deleted the patch-5 branch October 23, 2023 10:48
@zerothi
Copy link
Owner

zerothi commented Oct 23, 2023

Agreed, I haven't had time to look into GA caching... But that would indeed be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants