Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.process.Child: use clone() instead of fork() #22368

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

std.process.Child: use clone() instead of fork() #22368

wants to merge 9 commits into from
+334 −81

Conversation

ruihe774
Copy link
Contributor

@ruihe774 ruihe774 commented Dec 31, 2024 •
edited
Loading

See discussions in #1620.

This PR depends on #22341. (merged)

@ruihe774 ruihe774 force-pushed the clone branch 2 times, most recently from 0b61b7d to 57ee91d Compare December 31, 2024 04:32
@ruihe774
Copy link
Contributor Author

clone() does not work in .stage2_c. I disabled it in this case.

@ruihe774 ruihe774 force-pushed the clone branch 14 times, most recently from 6f31e98 to 351ce97 Compare December 31, 2024 09:39
@ruihe774
Copy link
Contributor Author

ruihe774 commented Dec 31, 2024 •
edited
Loading

I use clone3() in x86 and x86_64 so that I can use CLONE_CLEAR_SIGHAND if available. I'm not familiar with (and I cannot test) asm of other ISAs. Sorry.

@ruihe774 ruihe774 force-pushed the clone branch 2 times, most recently from 2ac3a31 to 0713379 Compare December 31, 2024 10:02
@ruihe774
Copy link
Contributor Author

@alexrp PTAL.

@ruihe774 ruihe774 force-pushed the clone branch 4 times, most recently from 27e8236 to 25c7f1b Compare December 31, 2024 13:16
@ruihe774 ruihe774 force-pushed the clone branch 2 times, most recently from e88bb54 to f57a745 Compare January 4, 2025 02:55
@ruihe774 ruihe774 mentioned this pull request Jan 5, 2025
Open
@ruihe774 ruihe774 requested a review from alexrp January 8, 2025 07:16
@alexrp alexrp mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrp alexrp Awaiting requested review from alexrp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruihe774 @alexrp