zig stdlib bug fix - write HTTP request privileged headers #22394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct
RequestOptionsin the stdlib's HTTP client has aprivileged_headersfield. This is useful for headers that should be stripped on an HTTP redirect. However, at the moment I don't think they are being written to the request at all, regardless of redirect. This PR fixes that.This also makes me think that the "authorization" built-in header in
Request.Headersshould be privileged by default, as it risks people exposing authorization info on redirects at the moment. Maybe I can open a separate issue for that.