Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry send records after auth exception #1286

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

erikvanoosten
Copy link
Collaborator

@erikvanoosten erikvanoosten commented Jul 18, 2024

Some brokers are sometimes too slow to authorize or authenticate a send. This results in spurious exceptions. With this change we retry sends unless the error happens too often.

Still todo:

  • make it a bit more efficient for the success case (e.g. only create schedule driver when necessary)
  • make retry setup more efficient (loop through only once to collect firstAuthError, authErrorCount and errorCount
  • add tests
  • fix comment typo firs auth error => first auth error

Todo:
- make it a bit more efficient for the success case (e.g. not create schedule driver)
- tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant