More efficient handling of different discriminator types #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plokhotnyuk
force-pushed
the
more-efficient-handling-different-discriminator-types
branch
2 times, most recently
from
9c92f58 to
9f1919f
Compare
plokhotnyuk
force-pushed
the
more-efficient-handling-different-discriminator-types
branch
14 times, most recently
from
d62eeed to
d6b92e6
Compare
…criminator field in parsed messages
…in decode methods
plokhotnyuk
force-pushed
the
more-efficient-handling-different-discriminator-types
branch
from
d6b92e6 to
e4badd0
Compare
jdegoes
approved these changes
Jan 8, 2025
plokhotnyuk
deleted the
more-efficient-handling-different-discriminator-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An intermediate PR before fixing inconsistency of handling of different discriminator types that was reported in this issue: #763
It contains a bunch of yak shaving commits to avoid copying all those redundant stuff for
Schema.GenericRecordcodecsIt would be better to review it on per commit basis