Skip to content

Commit

Permalink
compose_box [nfc]: On Windows, skip a test that fails.
Browse files Browse the repository at this point in the history
Skips the test that fails because of the platform
specific path separator being '\' instead of '/
on Windows.

Read this excellent explanation by
@chrisbobbe for better understanding:
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/failing.20composebox.20test.20while.20running.20check.20script/near/2000301

[greg: rewrote comment]
  • Loading branch information
apoorvapendse authored and Gaurav-Kushwaha-1225 committed Jan 8, 2025
1 parent a332f80 commit 076d0de
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion test/widgets/compose_box_test.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';
import 'dart:convert';
import 'dart:io';

import 'package:checks/checks.dart';
import 'package:file_picker/file_picker.dart';
Expand Down Expand Up @@ -581,7 +582,13 @@ void main() {
});

// TODO test what happens when capturing/uploading fails
});
},
// This test fails on Windows because [XFile.name] splits on
// [Platform.pathSeparator], corresponding to the actual host platform
// the test is running on, instead of the path separator for the
// target platform the test is simulating.
// TODO(upstream): unskip after fix to https://github.com/flutter/flutter/issues/161073
skip: Platform.isWindows);
});

group('error banner', () {
Expand Down

0 comments on commit 076d0de

Please sign in to comment.