Live Metrics Filtering Part 6: Error Tracker #43744
Open
+202
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
jeanbisutti
reviewed
Jan 9, 2025
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.FilterInfo; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class CustomDimensions { | ||
| private final Map<String, String> customDimensions; | ||
| private static ClientLogger logger = new ClientLogger(CustomDimensions.class); |
There was a problem hiding this comment.
Suggested change
| private static ClientLogger logger = new ClientLogger(CustomDimensions.class); | |
| private static final ClientLogger logger = new ClientLogger(CustomDimensions.class); |
| @@ -47,9 +49,13 @@ public double getCustomDimValueForProjection(String key) { | |||
| try { | |||
| return Double.parseDouble(value); | |||
| } catch (NumberFormatException e) { | |||
|
|
|||
| logger.verbose( | |||
| "The value for the custom dimension could not be converted to a numeric value for a derived metric projection"); | |||
There was a problem hiding this comment.
Suggested change
| "The value for the custom dimension could not be converted to a numeric value for a derived metric projection"); | |
| value + " for the custom dimension could not be converted to a numeric value for a derived metric projection"); |
| @@ -15,17 +16,26 @@ public class DependencyDataColumns implements TelemetryColumns { | |||
| private final CustomDimensions customDims; | |||
| private final Map<String, Object> mapping = new HashMap<>(); | |||
|
|
|||
| private static ClientLogger logger = new ClientLogger(DependencyDataColumns.class); | |||
There was a problem hiding this comment.
Suggested change
| private static ClientLogger logger = new ClientLogger(DependencyDataColumns.class); | |
| private static final ClientLogger logger = new ClientLogger(DependencyDataColumns.class); |
| mapping.put(KnownDependencyColumns.SUCCESS, rdData.isSuccess()); | ||
| mapping.put(KnownDependencyColumns.NAME, rdData.getName()); | ||
| int resultCode; | ||
| try { | ||
| resultCode = Integer.parseInt(rdData.getResultCode()); | ||
| } catch (NumberFormatException e) { | ||
| logger.verbose("The provided result code could not be converted to a numeric value: {}", |
There was a problem hiding this comment.
Suggested change
| logger.verbose("The provided result code could not be converted to a numeric value: {}", | |
| logger.verbose(rdData.getResultCode() + " result code could not be converted to a numeric value: {}", |
|
|
||
| long durationMicroSec = FormattedDuration.getDurationFromTelemetryItemDurationString(requestData.getDuration()); | ||
| if (durationMicroSec == -1) { | ||
| logger.verbose("The provided timestamp could not be converted to microseconds: {}", |
There was a problem hiding this comment.
Suggested change
| logger.verbose("The provided timestamp could not be converted to microseconds: {}", | |
| logger.verbose(requestData.getDuration() + " provided timestamp could not be converted to microseconds: {}", |
| mapping.put(KnownRequestColumns.NAME, requestData.getName()); | ||
| int responseCode; | ||
| try { | ||
| responseCode = Integer.parseInt(requestData.getResponseCode()); | ||
| } catch (NumberFormatException e) { | ||
| responseCode = -1; | ||
| logger.verbose("The provided response code could not be converted to a numeric value: {}", |
There was a problem hiding this comment.
Suggested change
| logger.verbose("The provided response code could not be converted to a numeric value: {}", | |
| logger.verbose(requestData.getResponseCode() + " provided response code could not be converted to a numeric value: {}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When parsing a new filtering configuration, this PR will also track configuration errors. Configuration errors are logged to applicationinsights.log at every config change. In addition, configuration errors are sent as a part of the post request body for as long as the faulty configuration is being used.
There is also some verbose level logging added for debug purposes.
Manual testing was done in addition to some modifications to existing tests.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines