Live Metrics Filtering Part 6: Error Tracker #43744
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| package com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.filtering; | ||
|
|
||
| import com.azure.core.util.logging.ClientLogger; | ||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.CollectionConfigurationError; | ||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.CollectionConfigurationErrorType; | ||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.KeyValuePairString; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class ConfigErrorTracker { | ||
| private final List<CollectionConfigurationError> errors = new ArrayList<>(); | ||
|
|
||
| private static final ClientLogger LOGGER = new ClientLogger(ConfigErrorTracker.class); | ||
|
|
||
| public void constructAndTrackCollectionConfigurationError(String message, String eTag, String id, | ||
| boolean isDerivedMetricId) { | ||
| CollectionConfigurationError error = new CollectionConfigurationError(); | ||
| error.setMessage(message); | ||
| error.setCollectionConfigurationErrorType(setErrorType(message)); | ||
|
|
||
| KeyValuePairString keyValuePair1 = new KeyValuePairString(); | ||
| keyValuePair1.setKey("ETag"); | ||
| keyValuePair1.setValue(eTag); | ||
|
|
||
| KeyValuePairString keyValuePair2 = new KeyValuePairString(); | ||
| keyValuePair2.setKey(isDerivedMetricId ? "DerivedMetricInfoId" : "DocumentStreamInfoId"); | ||
| keyValuePair2.setValue(id); | ||
|
|
||
| List<KeyValuePairString> data = new ArrayList<>(); | ||
| data.add(keyValuePair1); | ||
| data.add(keyValuePair2); | ||
|
|
||
| error.setData(data); | ||
|
|
||
| errors.add(error); | ||
| // This message gets logged once for every error we see on config validation. Config validation | ||
| // only happens once per config change. | ||
| LOGGER.verbose("{}. Due to this misconfiguration the {} rule with id {} will be ignored by the SDK.", message, | ||
| isDerivedMetricId ? "derived metric" : "document filter conjunction", id); | ||
| } | ||
|
|
||
| private CollectionConfigurationErrorType setErrorType(String message) { | ||
| if (message.contains("telemetry type")) { | ||
| return CollectionConfigurationErrorType.METRIC_TELEMETRY_TYPE_UNSUPPORTED; | ||
| } else if (message.contains("duplicate metric id")) { | ||
| return CollectionConfigurationErrorType.METRIC_DUPLICATE_IDS; | ||
| } | ||
| return CollectionConfigurationErrorType.FILTER_FAILURE_TO_CREATE_UNEXPECTED; | ||
| } | ||
|
|
||
| public List<CollectionConfigurationError> getErrors() { | ||
| return new ArrayList<CollectionConfigurationError>(errors); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |||||
|
|
||||||
| package com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.filtering; | ||||||
|
|
||||||
| import com.azure.core.util.logging.ClientLogger; | ||||||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.models.RemoteDependencyData; | ||||||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.FilterInfo; | ||||||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.utils.FormattedDuration; | ||||||
|
|
@@ -15,17 +16,26 @@ public class DependencyDataColumns implements TelemetryColumns { | |||||
| private final CustomDimensions customDims; | ||||||
| private final Map<String, Object> mapping = new HashMap<>(); | ||||||
|
|
||||||
| private static ClientLogger logger = new ClientLogger(DependencyDataColumns.class); | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| public DependencyDataColumns(RemoteDependencyData rdData) { | ||||||
| customDims = new CustomDimensions(rdData.getProperties(), rdData.getMeasurements()); | ||||||
| mapping.put(KnownDependencyColumns.TARGET, rdData.getTarget()); | ||||||
|
|
||||||
| long durationMicroSec = FormattedDuration.getDurationFromTelemetryItemDurationString(rdData.getDuration()); | ||||||
| if (durationMicroSec == -1) { | ||||||
| logger.verbose("The provided timestamp could not be converted to microseconds: {}", rdData.getDuration()); | ||||||
| } | ||||||
| mapping.put(KnownDependencyColumns.DURATION, durationMicroSec); | ||||||
|
|
||||||
| mapping.put(KnownDependencyColumns.SUCCESS, rdData.isSuccess()); | ||||||
| mapping.put(KnownDependencyColumns.NAME, rdData.getName()); | ||||||
| int resultCode; | ||||||
| try { | ||||||
| resultCode = Integer.parseInt(rdData.getResultCode()); | ||||||
| } catch (NumberFormatException e) { | ||||||
| logger.verbose("The provided result code could not be converted to a numeric value: {}", | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| rdData.getResultCode()); | ||||||
| resultCode = -1; | ||||||
| } | ||||||
| mapping.put(KnownDependencyColumns.RESULT_CODE, resultCode); | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
|
|
||
| package com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.filtering; | ||
|
|
||
| import com.azure.core.util.logging.ClientLogger; | ||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.AggregationType; | ||
| import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.DerivedMetricInfo; | ||
|
|
||
|
|
@@ -14,6 +15,8 @@ public class DerivedMetricProjections { | |
| public static final String COUNT = "Count()"; | ||
| private final Map<String, DerivedMetricAggregation> derivedMetricValues = new HashMap<>(); | ||
|
|
||
| private static final ClientLogger LOGGER = new ClientLogger(DerivedMetricProjections.class); | ||
|
|
||
| public DerivedMetricProjections(Map<String, AggregationType> projectionInfo) { | ||
| for (Map.Entry<String, AggregationType> entry : projectionInfo.entrySet()) { | ||
| AggregationType aggregationType = entry.getValue(); | ||
|
|
@@ -61,7 +64,10 @@ public void calculateProjection(DerivedMetricInfo derivedMetricInfo, TelemetryCo | |
| // For now, such cases produce Double.Nan and get skipped when calculating projection. | ||
| } | ||
|
|
||
| if (Double.isNaN(incrementBy)) { | ||
| LOGGER.verbose( | ||
| "This telemetry item will not be counted in derived metric projections because the Duration or a CustomDimension column could not be interpreted as a numeric value."); | ||
| } else { | ||
| calculateAggregation(derivedMetricInfo.getId(), incrementBy); | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.