Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Opendrive Parser Bugfix + Test Re-enable #193

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

Eric-Vin
Copy link
Collaborator

@Eric-Vin Eric-Vin commented Oct 4, 2023

Re-enables some tests and fixes a bug in the Opendrive parser, while adding an additional XODR file that triggers the bug to improve coverage.

@Eric-Vin Eric-Vin marked this pull request as draft October 4, 2023 21:50
@Eric-Vin Eric-Vin changed the title Opendrive Parser Bugfix + Test Re-enable [WIP] Opendrive Parser Bugfix + Test Re-enable Oct 4, 2023
@Eric-Vin
Copy link
Collaborator Author

Eric-Vin commented Oct 4, 2023

Should address Issue #189 once we get it working.

@Eric-Vin
Copy link
Collaborator Author

As of the above commit, this test failure can be reproduced. Will fix on this branch as it is related.

Command to reproduce:
pytest -k test_orientation_consistency --randomly-seed=2632358711

@Eric-Vin Eric-Vin changed the title [WIP] Opendrive Parser Bugfix + Test Re-enable Opendrive Parser Bugfix + Test Re-enable Feb 7, 2024
@Eric-Vin Eric-Vin requested a review from dfremont February 7, 2024 05:41
@Eric-Vin Eric-Vin marked this pull request as ready for review February 7, 2024 05:41
@Eric-Vin Eric-Vin marked this pull request as draft February 9, 2024 01:23
@Eric-Vin Eric-Vin changed the title Opendrive Parser Bugfix + Test Re-enable [WIP] Opendrive Parser Bugfix + Test Re-enable Feb 9, 2024
@Eric-Vin Eric-Vin mentioned this pull request Jul 18, 2024
3 tasks
@Eric-Vin Eric-Vin linked an issue Jul 18, 2024 that may be closed by this pull request
3 tasks
@Eric-Vin Eric-Vin linked an issue Jul 18, 2024 that may be closed by this pull request
@Eric-Vin
Copy link
Collaborator Author

Currently experiencing a Shapely crash, outlined here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom road map crashes Scenic I think that there are some typo in the code
1 participant