-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine layout and wording on page #63
Conversation
@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the tweaks! I like the new layout and content much more, just a few comments:
- "What are BuidlGuidl Batches?" sectopm could use a bit more spacing, at least in my laptop everything feels too tight. Mobile layout needs a review too.
- "What you'll learn?" section looks good to me!
- "How do Batches work?" something feels strange to me with this card layout, maybe that's a personal perception. I think we could use a bit extra spacing here too.
If needed we could ask Andrea, if she's available, to do a final review or give the designer touch.
…so that there are no issues for mobile
Thanks for the fast feedback! :) I fixed the mobile view (thanks for pointing out), added some more spacing and created two components. For the "How do Batches work?" I wanted to have another card layout that doesn't repeat that from the "What are BuidlGuidl Batches?". For me it seems good, but open to change it :) If Andrea has time that would be nice! :) |
Yeah I think is good enough! The pills felt a bit strange at start but it's fine! Everything looking good now, just a couple of nitpicks:
|
I added the spacing, definitely better! (Funny that I didn’t notice it earlier 😅) As for the order of the CTA and the table, I tried moving the CTA to the bottom, but I didn’t like it much. I’m happy with how it is now, but if you want to change it, let me know! |
@@ -172,28 +267,7 @@ const Batches = ({ batchData, openBatchNumber, openBatchStartDate }: PageProps) | |||
<div className="bg-[#EDEFFF] pt-16 lg:pt-24 pb-16"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe with pt-2 lg:pt-8
is enough spacing?
<div className="bg-[#EDEFFF] pt-16 lg:pt-24 pb-16"> | |
<div className="bg-[#EDEFFF] pt-2 lg:pt-8 pb-16"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge!
Added a small comment about the spacing from the last CTA to the above section, but can leave it as it is or tweak it however you see it better!
In the future if we feel the cards font size for the first section is too big, could lower it a bit 🙏
Just realized vercel build was failing, tried to
@phipsae think we need to move the new components to |
Thx! |
Description
Hi,
I've updated the layout and added more text to provide a clearer explanation of what we're doing (see the screenshots below).
I hope that's okay!
Thanks @Pabl0cks it is already a nice page! Open for feedback :)