-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine layout and wording on page #63
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0592d33
change - what are batches
phipsae 0a5ca72
add what you will learn section
phipsae 6dfa026
change how do batches work section
phipsae 5fab271
add batchCta component to reduce code repetition
phipsae a863b21
fix of what are BG batches section, more spacing and took out nowrap …
phipsae c8ebcd6
align bullet point text so that letters are always on some level
phipsae f7ab695
add card component and some spacing for how do batches work section
phipsae 6491689
add line spacing to card
phipsae c2325f1
move batches component und util into nextjs/components folder
phipsae 61c7ab8
decrease spacing inbetween how do batches work section and cta
phipsae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { formatDate } from "../utils/formatDate"; | ||
import TrackedLink from "~~/components/TrackedLink"; | ||
|
||
interface BatchCtaProps { | ||
openBatchNumber: number | null; | ||
openBatchStartDate: number | null; | ||
} | ||
|
||
export const BatchCta = ({ openBatchNumber, openBatchStartDate }: BatchCtaProps) => { | ||
return ( | ||
<div className="mt-16 mb-16 card bg-gradient-to-r from-primary to-secondary px-6 lg:pl-6 py-8 max-w-full xs:max-w-[90%] md:max-w-[75%] xl:max-w-[60%] mx-auto"> | ||
<div className="card-body py-0 px-0 lg:py-0 lg:px-10 flex flex-col lg:flex-row items-center justify-between gap-6"> | ||
<div className="max-w-full lg:max-w-[55%] text-center lg:text-left"> | ||
<h3 className="card-title text-2xl text-white mb-3 justify-center lg:justify-start"> | ||
Batch #{openBatchNumber} | ||
</h3> | ||
<p className="text-white"> | ||
Complete SpeedRunEthereum and join BuidlGuidl to be part of the next batch starting | ||
<strong>{openBatchStartDate ? ` on ${formatDate(openBatchStartDate)}` : " soon"}!</strong> | ||
</p> | ||
</div> | ||
<div className="flex justify-center lg:justify-end w-full lg:w-auto"> | ||
<TrackedLink | ||
id="apply-next-batch" | ||
href="https://speedrunethereum.com/" | ||
className="btn btn-sm bg-white text-primary hover:bg-gray-100 transition-colors duration-300 inline-flex items-center justify-center whitespace-nowrap" | ||
> | ||
Go SpeedRunEthereum | ||
</TrackedLink> | ||
</div> | ||
</div> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
interface CardProps { | ||
icon: string; | ||
title: string; | ||
description: string; | ||
} | ||
|
||
export const Card = ({ icon, title, description }: CardProps) => { | ||
return ( | ||
<div className="bg-white/60 rounded-lg p-4 shadow-sm transition-shadow"> | ||
<h3 className="font-bold mb-2 mt-2 leading-relaxed"> | ||
{icon} {title} | ||
</h3> | ||
<p className="text-gray-700 mb-0">{description}</p> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export const formatDate = (timestamp: number): string => { | ||
return new Date(timestamp).toLocaleDateString("en-US", { | ||
year: "numeric", | ||
month: "short", | ||
day: "numeric", | ||
}); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe with
pt-2 lg:pt-8
is enough spacing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed