Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use toFixed(18) when computing the ETH value in EtherInput.tsx #14

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Use toFixed(18) when computing the ETH value in EtherInput.tsx #14

merged 2 commits into from
Jun 11, 2024

Conversation

portdeveloper
Copy link
Member

This PR

  • Adds a constant MAX_DECIMALS_ETH = 18 to EtherInput.tsx, uses it in toFixed to compute the Ether value
chrome_R6ZulIeC5I.mp4

Closes #13

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sand-garden ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:26am

carletex
carletex approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!! Thanks @portdeveloper

@carletex carletex merged commit ebc84b4 into main Jun 11, 2024
3 checks passed
@carletex carletex deleted the fix/conversion-decimals branch June 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carletex carletex carletex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Switching between ETH and USD on withdraw modal crashes the app
2 participants
@portdeveloper @carletex