Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toFixed(18) when computing the ETH value in EtherInput.tsx #14

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Use toFixed(18) when computing the ETH value in EtherInput.tsx #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c0070
Use toFixed(18) when computing the ETH value in EtherInput.tsx
portdeveloper Jun 11, 2024
301d790
Merge branch 'main' into fix/conversion-decimals
carletex Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { CommonInputProps, InputBase, SIGNED_NUMBER_REGEX } from "~~/components/
import { useAppStore } from "~~/services/store/store";

const MAX_DECIMALS_USD = 2;
const MAX_DECIMALS_ETH = 18;

function etherValueToDisplayValue(usdMode: boolean, etherValue: string, ethPrice: number) {
if (usdMode && ethPrice) {
Expand All @@ -28,7 +29,7 @@ function displayValueToEtherValue(usdMode: boolean, displayValue: string, ethPri
return displayValue;
} else {
// Compute the ETH value if a valid number.
return (parsedDisplayValue / ethPrice).toString();
return (parsedDisplayValue / ethPrice).toFixed(MAX_DECIMALS_ETH).replace(/\.?0+$/, "");
}
} else {
return displayValue;
Expand Down
Loading