Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game crashes on startup #78966

Closed
ektoplazm opened this issue Jan 5, 2025 · 12 comments
Closed

game crashes on startup #78966

ektoplazm opened this issue Jan 5, 2025 · 12 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@ektoplazm
Copy link
Contributor

Describe the bug

game crashes on startup

DEBUG : Font file 'Terminus' does not exist.

FUNCTION : load_font
FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\cata_imgui.cpp
LINE : 381

Attach save file

happens on startup

Steps to reproduce

launch the game
witness the error message

Expected behavior

does not crash

Screenshots

No response

Versions and configuration

win 10
version c818cf9
build 2025-01-05-1539

Additional context

debug.log
crash.log

@ektoplazm ektoplazm added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 5, 2025
@GuardianDll
Copy link
Member

@CLIDragon can it be a consequence of #78830?

@Procyonae
Copy link
Contributor

Posting your config/fonts.json would be useful

@ektoplazm
Copy link
Contributor Author

fonts.json

@Procyonae
Copy link
Contributor

fonts.json
As a temporary workaround you can replace it with this (you can remove Roboto again if that was intentional like)

@Procyonae
Copy link
Contributor

The way we find the files is pretty funky and CLI's PR seems to be flagging extensionless fonts as invalid now when the code can (or at least could) deal with them fine (see #72922 (comment) for me attempting to figure out the code)

@ektoplazm
Copy link
Contributor Author

fonts.json As a temporary workaround you can replace it with this (you can remove Roboto again if that was intentional like)

thanks, it worked

@GuardianDll
Copy link
Member

throwing my two cents, i got this when i booted up my game

 DEBUG    : Font specifiers must be an array, object, or string.

 FUNCTION : load_font_from_config
 FILE     : E:\cddadev\src\font_loader.cpp
 LINE     : 126
 VERSION  : 0.G-16254-gf2be256031-dirty

@Procyonae
Copy link
Contributor

And your font file looks like? :^)

@harakka harakka added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jan 6, 2025
@CLIDragon
Copy link
Contributor

CLIDragon commented Jan 6, 2025

The way we find the files is pretty funky and CLI's PR seems to be flagging extensionless fonts as invalid now when the code can (or at least could) deal with them fine (see #72922 (comment) for me attempting to figure out the code)

We didn't support extensionless fonts before, we just failed without an error. However, it seems that I did accidentally break the font fallback code, see #78978.

EDIT: It turns out that we did support extensionless fonts. We do still support them for fonts loaded through SDL, namely gui_typeface, overmap_typeface, and map_typeface. However, based on reading #45319 this isn't something that is desired to continue.

@paulo-renzo
Copy link

I get the same error on android. When I replace fonts.json with the workaround file I get:

DEBUG : Font file 'data/font/Roboto-Medium.ttf' does not exist.

FUNCTION : void load_font(ImGuiIO &, const std::vector<font_config> &, const ImWchar *)
FILE : /home/runner/work/Cataclysm-DDA/Cataclysm-DDA/android/app/jni/src/../../../../src/cata_imgui.cpp
LINE : 381
VERSION : cdda-experimental-2025-01-06-2057 fd6b946

@CLIDragon
Copy link
Contributor

#78999 will fix this.

@RenechCDDA
Copy link
Member

Should be resolved by #78999

Please leave a comment if you're still experiencing this issue on a version newer than b940e14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants