fix fallback font rendering #78978
Closed
fix fallback font rendering #78978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
github-actions
bot
added
the
json-styled
github-actions
bot
added
the
astyled
|
Using the fonts.json in the linked issue, loading the game gets a font made of only rectangles instead of the expected font. This only occurs if |
db48x
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fallback font rendering works again"
Purpose of change
I accidentally broke fallback font rendering in #78830, causing #78966.
fixes #78966
Describe the solution
Add an else statement.
Describe alternatives you've considered
None.
Testing
Game no longer crashes with given font config file.
Additional context
I'm mildly surprised static analysis didn't catch this.