Json subway #68496
Draft
Json subway #68496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
data/json/overmap/overmap_special/lab_modular/lab_mutagen_6_floor.json
Outdated
Show resolved
Hide resolved
|
This is sick. Thanks for working on this! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
github-actions
bot
removed
the
stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
github-actions
bot
removed
the
stale
Procyonae
force-pushed
the
JSONSubway
branch
from
f708eaa to
4f6601d
Compare
github-actions
bot
added
the
<Bugfix>
Procyonae
force-pushed
the
JSONSubway
branch
from
4f6601d to
502a8a2
Compare
github-actions
bot
added
the
astyled
github-actions
bot
added
json-styled
github-actions
bot
added
json-styled
Procyonae
force-pushed
the
JSONSubway
branch
from
b0d8ecc to
409f073
Compare
github-actions
bot
added
the
Mods: Dinomod
github-actions
bot
added
BasicBuildPassed
|
Conflicts and astyle |
|
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/attempting-to-mod-subway-system/29147/2 |
github-actions
bot
added
Vehicles
This was referenced Apr 11, 2024
|
Closing as stale. If you wish to continue working on this, ping me to reopen. |
github-actions
bot
removed
BasicBuildPassed
Station Rotation Remove sub_connector s, mess with maps and make stations work Fix old lab walls Add generic z-2 to z-4 ramps Update test_microlab mutable Remove references to microlab_sub_connector and sewer connectors Make sub stations use connections Fix sewer_points Generic OMTs Conditional end nests No more vehicle placement stuff Minor map tweaks Add diagonal rail flag
Procyonae
force-pushed
the
JSONSubway
branch
2 times, most recently
from
2e2f894 to
403d4a3
Compare
github-actions
bot
added
json-styled
…oup + map changes, add some diagonal nests Involves several tinkering tweaks that aren't final
…outweighs the zero benefit it provides
github-actions
bot
added
the
NPC / Factions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Altered subway maps"
Purpose of change
Hardcode bad
Fixes #66220
Fixes #68957
Fixes #69789
Fixes #69821
Describe the solution
subwayto the z-4lab_subwaysewer_connectorandmicrolab_sub_connectorand replaces them with connectionscity_buildings to use connectionsDescribe alternatives you've considered
Changing/balancing monster spawns
Making lab stations on z-2 more obscured (looking out the window and seeing a reinforced door guarded by turrets and guards would probably raise eyebrows :^) )
Moving all lab stations to z-4
Making lab_subway use small rails
Changing subway to be 1 rail w/ passing places etc
Testing
Additional context
Requires #67736 for the full scope I want to achieve#67736 will make the subway spawns more sensical but this is still an upgrade on what we have so I'll just do this first. Basically the connections have some hardcoded stuff only designed for roads so you get silliness like subways pathing to dead ends under the centre of cities which causes them to often not be fully interconnected within an OM.
Still to do:
In followup PRs (this was all intended for this PR originally but I want it merged sooner):
Improve mall + hub 01 + microlab_sub_station + central_lab_train_depot + underground_lab_cargo_stationA stations
Station variation + beautification
Vent shaft nest that appears at random
Add non-guarenteed stations for a few maps like the stadium/mines
Possibly in a followup PR:
A region setting controlled vent nest above each subway at regular intervals when there's nothing in the way, placed after all other mapgen