-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bone audit - 1/? #74364
Merged
Merged
Bone audit - 1/? #74364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jun 7, 2024
It appears you modified a |
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Info / User Interface
Game - player communication, menus, etc.
Translation
I18n
Items: Magazines
Ammo holding items and objects.
Missions
Quests and missions
Bionics
CBM (Compact Bionic Modules)
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Vehicles
Vehicles, parts, mechanics & interactions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Spawn
Creatures, items, vehicles, locations appearing on map
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
Monsters
Monsters both friendly and unfriendly.
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[Markdown]
Markdown issues and PRs
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
Melee
Melee weapons, tactics, techniques, reach attack
Scenarios
New Scenarios, balancing, bugs with scenarios
Character / World Generation
Issues and enhancements concerning stages of creating a character or a world
[Python]
Code made in Python
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Aftershock
Anything to do with the Aftershock mod
labels
Jun 11, 2024
Karol1223
removed
Items: Containers
Things that hold other things
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Items: Armor / Clothing
Armor and clothing
labels
Jun 11, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 11, 2024
Karol1223
force-pushed
the
bone-o'clock
branch
2 times, most recently
from
June 24, 2024 07:41
3c8ccd1
to
bf3f029
Compare
github-actions
bot
added
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mods: Magiclysm
Anything to do with the Magiclysm mod
labels
Jun 30, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Our bone items were, although good, still not exactly normalized and kind of all over the place. This, combined with #74328 which finally allows me to make corpses leave bones behind as they decay (but need some new bone types, so you don't get to make bone broth out of dessicated rotten bones) requires me to finally step up and set the stage. I really wanna add decay fields.Since #74462 is in limbo and I have no idea what to do with myself, this is devolving to just auditing some currently existing bone items. Nothing new is going to be added anymore.Describe the solution
Default bones
to-hit
calculation as well as some shitty bash damagecopy-from
from the base, remove its kcalWeird huge museum bone thing
length
modifier to long from shortBone meals
copy-from
Skulls
Misc shit
to-hit
since it had no damage defined anywayDescribe alternatives you've considered
Testing
Additional context