Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate extended description (x->e) to imgui #76308

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Migrate extended description (x->e) to imgui #76308

merged 2 commits into from
Sep 17, 2024

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Sep 9, 2024 •
edited
Loading

Summary

Infrastructure "Migrate extended description (x->e) to imgui"

Purpose of change

More imgui migration. But mostly I want the descriptions themselves for #55503, and this is a good way to split it off from that PR.

Describe the solution

This includes both a migration to imgui and a slight rework of the descriptions to improve their usefulness.

Describe alternatives you've considered

Testing

  1. x look around
  2. e various creatures, furnitures, terrains and vehicles

Additional context

NPC:
grafik

Monster:
grafik

Furniture:
grafik

Terrain:
grafik

Vehicle:
grafik

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Info / User Interface Game - player communication, menus, etc. Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 9, 2024
@mqrause mqrause force-pushed the imgui_extended_description branch from 195e383 to 69d4b0f Compare September 10, 2024 11:13
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 10, 2024
db48x
db48x suggested changes Sep 10, 2024
View reviewed changes
src/character.cpp Show resolved Hide resolved
@mqrause mqrause force-pushed the imgui_extended_description branch from 69d4b0f to 60f6900 Compare September 11, 2024 09:39
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 11, 2024
@mqrause mqrause force-pushed the imgui_extended_description branch from 60f6900 to d1504a0 Compare September 11, 2024 19:33
@mqrause mqrause marked this pull request as ready for review September 11, 2024 19:35
db48x
db48x suggested changes Sep 11, 2024
View reviewed changes
src/character.cpp Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 11, 2024
@mqrause mqrause force-pushed the imgui_extended_description branch from d1504a0 to 2dbe68a Compare September 12, 2024 14:59
@mqrause mqrause force-pushed the imgui_extended_description branch from 2dbe68a to 988d467 Compare September 12, 2024 19:45
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 12, 2024
@Maleclypse Maleclypse merged commit e40a6ef into CleverRaven:master Sep 17, 2024
26 checks passed
@mqrause mqrause deleted the imgui_extended_description branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@db48x db48x db48x requested changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqrause @db48x @Maleclypse