Fire action accounts for all kinds of shoulder straps #78744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
|
monster_throwing_sanity_test do not pass very consistenty for a random error, do you happen to know can your PR affect it somehow? |
I've noticed only "adjustable strap" works with the fire action to drawn weapon, and only with default format (hanging like backpack). Happens that code checks for that specific item. Solution is to check for a flag instead, and so works with all kinds of attachments
andrewhr
force-pushed
the
fix-shoulder-strap-fire-action
branch
from
10210a2 to
3567abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fire action works with all shoulder straps"
Purpose of change
I've noticed only "adjustable strap" works with the fire action to drawn weapon, and only with default format (hanging like backpack). Happens that code checks for that specific item ID.
Describe the solution
Check for any BELTED gunmod, assuming straps will make the weapon "BELTED".
Describe alternatives you've considered
Testing
Boot game, wear weapon and invoke fire action. Modify attachment to (front), wear and invoke fire action again.
Additional context