Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishes #61071 "Combat Adaptation -> Berserk (rework)" #79022

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CwasCard
Copy link
Contributor

@CwasCard CwasCard commented Jan 8, 2025

Summary

Features "Reworks Beast's Combat Adaptation into Berserk, adds Berserk fighting style accessible while BERSERK! is active."

Purpose of change

Finishes #61071 with a couple of my own additions.

Describe the solution

Combat Adaptation is replaced with Berserk, a mutation that can be activated to turn into BERSERK!. When BERSERK! is active, the character cannot block or dodge, their strength is increased by 14, their intelligence is decreased by 20, they move 30% faster and they cannot feel any new pain. They also gain access to the BERSERK! fighting style which scales heavily off of their now-increased strength. Anywhere from 2 to 5 minutes from activation, the BERSERK! effect wears off, and they instead experience a -6 modifier to their Strength, Perception, and Dexterity, a surge of pain and -30 speed for 10 minutes. They are additionally dazed for 30 seconds.

The BERSERK! style is much stronger while the user has the Natural Stance effect - the damage is higher and the techniques - aside from Overwhelm - don't require the user to have crit to take effect.

Describe alternatives you've considered

Instead of allowing Berserk to be activated manually, change it to be a random activation any time the user gets hit while a hostile is visible. This would require both the buffs and nerfs to be flattened down. I would like to keep the Berserk style in some form, though.

Testing

Start a world, give myself Beast threshold, Berserk mutation. Activate, watch effects. Wait for 5 minutes, Berserk comedown starts at 2 minutes. Berserk comedown lasts for 10. Give myself Digitigrade & Paws, activate Berserk again after the comedown, I only use the Natural Stance version of BERSERK!

Additional context

This is a question for anyone who's interested in answering - do you have any ideas for how to simulate multiple limbs without the WIP Limb Framework? I'd like to re implement #78982 in accordance with Maleclypse's suggestions (and in so doing give Chimera lots of extra goodies). I have an idea of where to start, but I'm not sure how to meaningfully and satisfyingly implement the "multiple limbs" part.

also I finally remembered to lint this time haha

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Martial Arts Arts, Techniques, weapons and anything touching martial arts. EOC: Effects On Condition Anything concerning Effects On Condition <Enhancement / Feature> New features, or enhancements on existing labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Flavortext, you go berserk. Comedown's terrible, make sure you're in a safe spot or else you're as good as dead.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 8, 2025
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 8, 2025
Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These numbers are completely out of line, +4 strength would be high enough that I'd ask for a more in depth analysis and rationale, +10% speed likewise, and that's a far as I got because your numbers are multiples of that.

@CwasCard
Copy link
Contributor Author

CwasCard commented Jan 8, 2025

These numbers are completely out of line, +4 strength would be high enough that I'd ask for a more in depth analysis and rationale, +10% speed likewise, and that's a far as I got because your numbers are multiples of that.

Alright. Are +2 and 5% (and other such squishdowns) more reasonable?

Squishes BERSERK's strength & speed down to 2 & 10% respectively. Removes a lot of the damage scaling from BERSERK!'s techniques as well.
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 8, 2025
@worm-girl
Copy link
Contributor

These numbers are completely out of line, +4 strength would be high enough that I'd ask for a more in depth analysis and rationale, +10% speed likewise, and that's a far as I got because your numbers are multiples of that.

Alright. Are +2 and 5% (and other such squishdowns) more reasonable?

I honestly think just disabling (or seriously reducing) pain maluses for the duration would be good enough to make players want to push the button. If you really wanted to, a short term morale boost from the flood of endorphines or whatever (plus a crash after) wouldn't go amiss. Beast is already quite strong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Martial Arts Arts, Techniques, weapons and anything touching martial arts. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants