Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 404 from S3 when re-requesting manifest after it expired (#6441) #6760

Merged
merged 31 commits into from
Dec 16, 2024

Restart manifest generations when manifest has expired (#6441)

6ec7b4f
Select commit
Loading
Failed to load commit list.
Merged

Fix: 404 from S3 when re-requesting manifest after it expired (#6441) #6760

Restart manifest generations when manifest has expired (#6441)
6ec7b4f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2024 in 1s

85.55% (target 80.00%)

View this Pull Request on Codecov

85.55% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 87.71429% with 43 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (1db6db7) to head (6ec7b4f).

Files with missing lines Patch % Lines
test/integration_test.py 0.00% 39 Missing ⚠️
src/azul/service/manifest_controller.py 94.73% 2 Missing ⚠️
src/azul/__init__.py 66.66% 1 Missing ⚠️
src/azul/service/async_manifest_service.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6760      +/-   ##
===========================================
- Coverage    85.55%   85.55%   -0.01%     
===========================================
  Files          153      153              
  Lines        21005    21170     +165     
===========================================
+ Hits         17971    18111     +140     
- Misses        3034     3059      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.