-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use our own GitHub Action in our demos #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Just a small suggestion to use a newer version.
@@ -25,11 +25,9 @@ jobs: | |||
persist-credentials: false | |||
|
|||
- name: Mount EESSI CernVM-FS software repository | |||
uses: cvmfs-contrib/github-action-cvmfs@55899ca74cf78ab874bdf47f5a804e47c198743c # v4.0 | |||
uses: eessi/github-action-eessi@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to use the latest version (v3.1) of our github action. See EESSI/github-action-eessi@v3.0.0...v3.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it loose implies using the latest v3
release (so v3.1.0
today and v3.2.0
when it comes out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the reason that referencing GitHub Actions by tag is insecure, since you can change the commit the tag points to at any point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that. Thanks for clarifying it. Would we want to use then a specific commit instead of v3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's our own action and one of the few places we use it, it's a good thing to actually see whether it breaks on new releases
No description provided.