Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own GitHub Action in our demos #40

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Use our own GitHub Action in our demos #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/software_repo_native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ jobs:
persist-credentials: false

- name: Mount EESSI CernVM-FS software repository
uses: cvmfs-contrib/github-action-cvmfs@55899ca74cf78ab874bdf47f5a804e47c198743c # v4.0
uses: eessi/github-action-eessi@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use the latest version (v3.1) of our github action. See EESSI/github-action-eessi@v3.0.0...v3.1.0

Copy link
Member Author

@ocaisa ocaisa Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it loose implies using the latest v3 release (so v3.1.0 today and v3.2.0 when it comes out)

Copy link
Member Author

@ocaisa ocaisa Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the reason that referencing GitHub Actions by tag is insecure, since you can change the commit the tag points to at any point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know that. Thanks for clarifying it. Would we want to use then a specific commit instead of v3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's our own action and one of the few places we use it, it's a good thing to actually see whether it breaks on new releases

with:
cvmfs_config_package: https://github.com/EESSI/filesystem-layer/releases/download/latest/cvmfs-config-eessi_latest_all.deb
cvmfs_http_proxy: DIRECT
cvmfs_repositories: software.eessi.io
eessi_stack_version: '2023.06'

- name: Run demo
run: |
Expand Down