Test fixes

[johnmay]

This cleans up the test suite significantly to run more consistently and faster.

• Make it so tests work on FlatLAF
• Reorganise tests into fewer classes reusing the same frame/panel more - this required some tweaks as the tests have side effects but nothing too major.

[github-actions]

	Tests	Passed ✅	Skipped	Failed
JUnit Test Report	88 ran	88 passed	0 skipped	0 failed

• View JUnit Test Report

[egonw]

I gets stuck on drawing a reaction:

It gets to this but then hangs...

update: @johnmay, I tried to fix it, but do not know how. The following did not work:

iff --git a/core/src/test/java/org/openscience/jchempaint/DrawingTest.java b/core/src/test/java/org/openscience/jchempaint/DrawingTest.java
index 8ca42a8e..0a9acac4 100644
--- a/core/src/test/java/org/openscience/jchempaint/DrawingTest.java
+++ b/core/src/test/java/org/openscience/jchempaint/DrawingTest.java
@@ -428,7 +428,7 @@ public class DrawingTest extends AbstractUITest {
 
                // we do target.doClick on the parent menu as otherwise FlatLAF gets stuck
                frame.menuItem("reaction").target.doClick();
-               frame.menuItem("addProductToExistingReaction").click();
+               frame.menuItem("addProductToExistingReaction").target.doClick();
 
                Assert.assertEquals(1, panel.getChemModel().getReactionSet().getReactionCount());
                Assert.assertEquals(1, panel.getChemModel().getReactionSet().getReaction(0).getReactantCount());

[johnmay]

I think this is just the nature of UI tests and slightly different interactions.
Note the tests are run as part of the build now and all passing there.

[johnmay]

Maybe try...

frame.menuItem("reaction").component().setVisible(true);
frame.menuItem("addProductToExistingReaction").click();

[johnmay]

The issue is the way submenu's work, they are not visible until mouse overed

[johnmay]

Sorry... this.

frame.menuItem("reaction").component().menuSelectionChanged(true);
frame.menuItem("addProductToExistingReaction").target.doClick();

I am probably going to remove that functionality anyways. As soon as you have multiple arrows it's a bit wonky

[egonw]

frame.menuItem("reaction").component().menuSelectionChanged(true);
frame.menuItem("addProductToExistingReaction").target.doClick();

That solved it.

[johnmay]

Why did you close without merging? What is needed?

[egonw]

Merged.