[FIX] Prevent infinite input loop when testing with readline in non-interactive mode #365
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itislu
force-pushed
the
fix-input-infinite-loop
branch
from
6f10b26 to
e14db14
Compare
|
The test failed because after the changes to the tester it needs the following change: 918116e
Oh I was wrong, the necessary change mentioned above was just so we can see the output of valgrind. |
LeaYeh
force-pushed
the
fix-input-infinite-loop
branch
2 times, most recently
from
a132e99 to
61ef9fd
Compare
itislu
force-pushed
the
fix-input-infinite-loop
branch
from
61ef9fd to
9d9c5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would look like this:
