[FIX] Prevent infinite input loop when testing with readline in non-interactive mode

include/defines.h

@@ -115,6 +115,9 @@
 # define PT_ROW_NUM			192
 # define UNDEFINED_STATE	-1
 
+/* User Input */
+# define MAX_INPUT_RETRIES	5
+
 /* Export */
 # define EXPORT_PREFIX		"export "
 

include/utils.h

@@ -18,9 +18,9 @@
 /* User input utils */
 bool		read_input(
 				char **line,
+				t_sh *shell,
 				char *prompt,
-				bool add_to_history,
-				bool is_interactive);
+				bool add_to_history);
 
 /* Token list utils */
 t_tok		*init_token(t_tok_typ type, char *data);

source/backend/redirection/heredoc.c

@@ -109,7 +109,7 @@ static t_hd_st	read_heredoc(t_sh *shell, t_list **line_list, char *here_end)
 	while (true)
 	{
 		line = NULL;
-		if (!read_input(&line, HEREDOC_PROMPT, false, shell->is_interactive))
+		if (!read_input(&line, shell, HEREDOC_PROMPT, false))
 			return (free(line), HD_ERROR);
 		if (shell->exit_code == TERM_BY_SIGNAL + SIGINT)
 			return (free(line), HD_ABORT);

source/main.c

@@ -28,7 +28,7 @@ int	main(void)
 	print_welcome_msg(&shell);
 	while (true)
 	{
-		if (!read_input(&shell.input_line, PROMPT, true, shell.is_interactive))
+		if (!read_input(&shell.input_line, &shell, PROMPT, true))
 			continue ;
 		if (!shell.input_line)
 			exec_exit(&shell, NULL);

source/shell/clean.c

@@ -21,7 +21,7 @@ static void	close_std_io(void);
 void	clean_and_exit_shell(t_sh *shell, int exit_code, char *msg)
 {
 	if (msg)
-		print_error("%s\n", msg);
+		print_error("%s: %s\n", PROGRAM_NAME, msg);
 	clean_shell(shell);
 	safe_close_all_pipes(shell);
 	free_get_next_line();

source/utils/user_input_utils.c

@@ -10,35 +10,53 @@
 /*                                                                            */
 /* ************************************************************************** */
 
-#include "defines.h"
+#include "clean.h"
+#include "utils.h"
+
+static bool	limit_retries(t_sh *shell, bool success);
 
 bool	read_input(
 			char **line,
+			t_sh *shell,
 			char *prompt,
-			bool add_to_history,
-			bool is_interactive)
+			bool add_to_history)
 {
 	char	*tmp;
 
 	errno = SUCCESS;
-	if (is_interactive)
+	if (shell->is_interactive)
 		*line = readline(prompt);
 	else
 	{
 		tmp = get_next_line(STDIN_FILENO);
 		if (errno != SUCCESS)
-			return (free(tmp), false);
+			return (free(tmp), limit_retries(shell, false));
 		if (tmp)
 		{
 			*line = ft_strtrim(tmp, "\n");
 			free(tmp);
 		}
 	}
-	if (errno == EINTR)
+	if (errno == EINTR || errno == ENOTTY)
 		errno = SUCCESS;
 	else if (errno != SUCCESS)
-		return (false);
-	if (add_to_history && *line && **line)
+		return (limit_retries(shell, false));
+	if (add_to_history && shell->is_interactive && *line && **line)
 		add_history(*line);
-	return (errno == SUCCESS);
+	return (limit_retries(shell, errno == SUCCESS));
+}
+
+static bool	limit_retries(t_sh *shell, bool success)
+{
+	static int	retries;
+
+	if (success == true)
+	{
+		retries = 0;
+		return (true);
+	}
+	else if (++retries > MAX_INPUT_RETRIES)
+		clean_and_exit_shell(shell, GENERAL_ERROR, "read input failed");
+	print_error("%s: read input failed, trying again...\n", PROGRAM_NAME);
+	return (false);
 }