Switch deployment workflow to re-usable action. #126
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 5 5
Lines 747 747
Branches 127 127
=======================================
Hits 654 654
Misses 56 56
Partials 37 37 ☔ View full report in Codecov by Sentry. |
.github/workflows/deploy.yaml
Outdated
| repository_url: https://test.pypi.org/legacy/ | ||
| token: ${{ secrets.TEST_PYPI_API_TOKEN }} | ||
| test_submission: true | ||
| package_name: 'gridData' |
.github/workflows/deploy.yaml
Outdated
| with: | ||
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| token: ${{ secrets.PYPI_API_TOKEN }} | ||
| package_name: 'gridData' |
There was a problem hiding this comment.
Same question above -- this variable is used for pip install, right?
There was a problem hiding this comment.
No it's used for the pytest --pyargs call, I think this is correct.
There was a problem hiding this comment.
ah wait I messed up somewhere
There was a problem hiding this comment.
blergh what a pain - I'll have to change the action to account for this... funilly enough it didn't trip up mda_xdrlib at all.
There was a problem hiding this comment.
Huh I guess I never fully realised pip doesn't care between - and _ in package names.
There was a problem hiding this comment.
Ah, I can't believe I keep spending the effort on typing underscores now 😂 better safe than sorry I guess
This switches the deployment to a re-usable action for a little bit more consistency across our ecosystem, and also some additional tests.