fix: Fix background popup client connection count

[jiexi]

Description

Currently it is possible to open more than one extension popup (the window that opens when you click on the extension icon from the browser toolbar), but background currently only considers it possible to have one open. This results in a bug where if two or more popups are open and one is closed, any ongoing gas fee polling will stop for all popups not just the one recently closed. This PR fixes this by changing the variable that tracks popup connection counts from a boolean to an int.

Related issues

Fixes:

Manual testing steps

1. Open two browser windows
2. Open one extension popup
3. In that popup, get to the confirmation screen for sending a transaction
4. The gas fee should be updating periodically
5. In the other window, open an extension popup
6. The gas fee should be updating periodically
7. Close any popup

• NOTE: The gas fee will change to a very low number before updating back to the correct amount. This seems to be a separate bug

8. The gas fee should be updating periodically still in the popup still open

Screenshots/Recordings

Before

After

Screen.Recording.2024-03-19.at.9.31.05.AM.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/background.js

Function	Unhandled Issue
setupController	TypeError: Cannot read properties of undefined (reading 'getCurrentBlock') new exports.default(app/scrip... Event Count: 18 Affected Users: 0
setupController	Error: Account Id f32a1223-62f2-4fb1-9d37-f10cd4a8ad8f not found new MetamaskController(app/scripts/metamas... Event Count: 1 Affected Users: 0

---

_{Did you find this useful? React with a 👍 or 👎}

[metamaskbot]

Builds ready [499522d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1288 ± 538 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	208	121	36	17
		domContentLoaded	11	58	26	13	6
		load	56	2892	1288	1120	538
		domInteractive	11	58	26	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 4 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [df03fb2]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1043 ± 570 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	382	139	69	33
		domContentLoaded	12	79	28	20	10
		load	65	3123	1043	1187	570
		domInteractive	12	79	28	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 4 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [f32046c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (489 ± 391 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	261	115	56	27
		domContentLoaded	10	77	30	23	11
		load	54	2320	489	814	391
		domInteractive	10	77	30	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 4 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (fc0e886) to head (f32046c).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23583   +/-   ##
========================================
  Coverage    68.82%   68.82%           
========================================
  Files         1170     1170           
  Lines        44389    44389           
  Branches     11879    11879           
========================================
  Hits         30549    30549           
  Misses       13840    13840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut.