refactor: remove extraneous type attribute from script, link (stylesheet), and style tags

[davidmurdoch]

On HTML5 documents the default type for script tags is "text/javascript", the default type for link tags with rel='stylesheet' is "text/css", and the default type for style tags is also "text/css".

For the skeptical reviewer, here is the documentation to back up my claims:

script

Authors should omit the type attribute instead of redundantly setting it.

https://html.spec.whatwg.org/dev/scripting.html#attr-script-type

link rel="stylesheet"

link element's type attribute is advisory:

User agents must not consider the type attribute authoritative — upon fetching the resource, user agents must not use the type attribute to determine its actual type.

from https://html.spec.whatwg.org/#processing-the-type-attribute

The default type for resources given by the stylesheet keyword is text/css.

https://html.spec.whatwg.org/#link-type-stylesheet

style

type Deprecated
This attribute should not be provided: if it is, the only permitted values are the empty string or a case-insensitive match for text/css

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style#type

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [ac0cd7f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (547 ± 380 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	183	109	28	13
		domContentLoaded	9	71	32	18	9
		load	57	2041	547	791	380
		domInteractive	9	71	32	18	9

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [d6798dd]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1205 ± 591 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	383	170	84	40
		domContentLoaded	9	155	45	36	17
		load	56	2942	1205	1231	591
		domInteractive	9	155	45	36	17

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (207f6af) to head (d6798dd).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23674   +/-   ##
========================================
  Coverage    69.13%   69.13%           
========================================
  Files         1160     1160           
  Lines        44260    44260           
  Branches     11839    11839           
========================================
  Hits         30596    30596           
  Misses       13664    13664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.