Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove extraneous type attribute from script, link (stylesheet), and style tags #23674

Merged
merged 3 commits into from
Mar 28, 2024
Merged

refactor: remove extraneous type attribute from script, link (stylesheet), and style tags #23674

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b6e6dd
refactor: remove extraneous JS type attributes
davidmurdoch Mar 24, 2024
ac0cd7f
refactor: remove extraneous css type attributes
davidmurdoch Mar 24, 2024
d6798dd
Merge branch 'develop' into refactor-remove-js-type
davidmurdoch Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/background.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8">
</head>
<body>
<script src="./load-background.js" type="text/javascript" charset="utf-8"></script>
<script src="./chromereload.js" type="text/javascript" charset="utf-8"></script>
<script src="./load-background.js" charset="utf-8"></script>
<script src="./chromereload.js" charset="utf-8"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions app/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<% } else { %>
<title>MetaMask</title>
<% } %>
<link rel="stylesheet" type="text/css" href="./index.css">
<link rel="stylesheet" href="./index.css">
</head>
<body>
<div id="app-content">
<img class="loading-logo" src="./images/logo/metamask-fox.svg" alt="" loading="lazy" />
<img class="loading-spinner" src="./images/spinner.gif" alt="" loading="lazy" />
</div>
<div id="popover-content"></div>
<script src="./load-app.js" type="text/javascript" charset="utf-8" async></script>
<script src="./load-app.js" charset="utf-8" async></script>
</body>
</html>
4 changes: 2 additions & 2 deletions app/loading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<script src="./snow.js" type="text/javascript" charset="utf-8"></script>
<script src="./use-snow.js" type="text/javascript" charset="utf-8"></script>
<script src="./snow.js" charset="utf-8"></script>
<script src="./use-snow.js" charset="utf-8"></script>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
Expand Down
9 changes: 2 additions & 7 deletions app/notification.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
margin-top: 1rem;
}
</style>
<link rel="stylesheet" type="text/css" href="./index.css" />
<link rel="stylesheet" href="./index.css" />
</head>
<body class="notification">
<div id="app-content">
Expand All @@ -50,11 +50,6 @@
/>
</div>
<div id="popover-content"></div>
<script
src="./load-app.js"
type="text/javascript"
charset="utf-8"
async
></script>
<script src="./load-app.js" charset="utf-8" async></script>
</body>
</html>
4 changes: 2 additions & 2 deletions app/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1 user-scalable=no">
<title>MetaMask</title>
<link rel="stylesheet" type="text/css" href="./index.css">
<link rel="stylesheet" href="./index.css">
</head>
<body style="width:357px; height:600px;">
<div id="app-content">
<img class="loading-logo" src="./images/logo/metamask-fox.svg" alt="" loading="lazy" />
<img class="loading-spinner" src="./images/spinner.gif" alt="" loading="lazy" />
</div>
<div id="popover-content"></div>
<script src="./load-app.js" type="text/javascript" charset="utf-8" async></script>
<script src="./load-app.js" charset="utf-8" async></script>
</body>
</html>
6 changes: 3 additions & 3 deletions app/trezor-usb-permissions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<script src="./snow.js" type="text/javascript" charset="utf-8"></script>
<script src="./use-snow.js" type="text/javascript" charset="utf-8"></script>
<script src="./snow.js" charset="utf-8"></script>
<script src="./use-snow.js" charset="utf-8"></script>
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,user-scalable=0" />
Expand Down Expand Up @@ -31,5 +31,5 @@
</head>
<body>
<iframe id="trezor-usb-permissions" src="https://connect.trezor.io/9/extension-permissions.html" allow="usb" frameborder="0" width="100%" height="100%"></iframe>
<script type="text/javascript" src="./vendor/trezor/usb-permissions.js"></script>
<script src="./vendor/trezor/usb-permissions.js"></script>
</body>
11 changes: 4 additions & 7 deletions development/charts/flamegraph/chart/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="../lib/d3-flamegraph.css" />
<link rel="stylesheet" href="../lib/d3-flamegraph.css" />

<style>
/* Space out content a bit */
Expand Down Expand Up @@ -73,13 +73,10 @@ <h3 class="text-muted">d3-flame-graph</h3>
<script src="https://d3js.org/d3.v7.js" charset="utf-8"></script>

<!-- d3-flamegraph -->
<script type="text/javascript" src="../lib/d3-flamegraph.js"></script>
<script
type="text/javascript"
src="../lib/d3-flamegraph-tooltip.js"
></script>
<script src="../lib/d3-flamegraph.js"></script>
<script src="../lib/d3-flamegraph-tooltip.js"></script>

<script type="text/javascript">
<script>
var chart = flamegraph()
.width(960)
.cellHeight(18)
Expand Down
2 changes: 1 addition & 1 deletion development/charts/table/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<html>
<head>
<script type="text/javascript" src="./jquery.min.js"></script>
<script src="./jquery.min.js"></script>
<style>
table {
border: 1px solid black;
Expand Down
4 changes: 2 additions & 2 deletions development/ts-migration-dashboard/app/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1 user-scalable=no">
<title>Extension TypeScript Migration Status</title>
<link rel="stylesheet" type="text/css" href="index.css">
<link rel="stylesheet" href="index.css">
</head>
<body>
<div id="app"></div>
<script src="index.js" type="text/javascript" charset="utf-8"></script>
<script src="index.js" charset="utf-8"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion offscreen/offscreen.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>MetaMask Offscreen Page</title>
</head>
<body>
<script type="text/javascript" src="./load-offscreen.js"></script>
<script src="./load-offscreen.js"></script>
<iframe
src="https://metamask.github.io/eth-ledger-bridge-keyring"
allow="hid"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/mock-page-with-disallowed-iframe/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<title>Mock E2E Phishing Page</title>
</head>
<script type="text/javascript">
<script>
function setIframeSource() {
const urlSearchParams = new URLSearchParams(window.location.search);
const params = Object.fromEntries(urlSearchParams.entries());
Expand Down
Loading