Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add lnk network logo #29493

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: add lnk network logo #29493

merged 1 commit into from
Jan 8, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 8, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add Ink network according to (network information)[https://docs.inkonchain.com/general/network-information] and ensure ink.svg is displayed properly
  2. Add Ink Sepolia network according to (network information)[https://docs.inkonchain.com/general/network-information] and ensure ink-sepolia.svg is supported

Screenshots/Recordings

Before

Screenshot 2024-12-19 at 3 35 46 PM

After

Screenshot 2024-12-19 at 3 35 12 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jan 8, 2025
@salimtb salimtb marked this pull request as ready for review January 8, 2025 09:41
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb mentioned this pull request Jan 8, 2025
7 tasks
@metamaskbot
Copy link
Collaborator

Builds ready [f89c7e1]
Page Load Metrics (1894 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24221871723505242
domContentLoaded15662128186014067
load16002187189415173
domInteractive25107442010
backgroundConnect10139373015
firstReactRender1774412211
getState55617168
initialActions01000
loadScripts11231633138912962
setupStore75815157
uiStartup18352612216017685

@salimtb salimtb added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 0861cb8 Jan 8, 2025
85 checks passed
@salimtb salimtb deleted the fix/add-lnk-network-logo branch January 8, 2025 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants