Grid sticky functionality fixed in full pages #2960
Conversation
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adi-unni
changed the title
src/components/table-of-contents/example-table-of-contents-sticky-full-page.njk
Outdated
Show resolved
Hide resolved
src/components/table-of-contents/example-table-of-contents-sticky-full-page.njk
Show resolved
Hide resolved
|
Actually maybe we should add a test to this. One that loads the page example, scrolls to the bottom and checks that the table of contents is still in view. Will stop the bug breaking again. |
Okay sure, I will work on that test and add it in |
|
All look sgood to me :) One note for next time , I have noticed that your branch doesn't follow the convention stated in the docs here. You can leave this branch names as it is but let's make sure to all stick to the rule defined in the docs :) |
|
Other than my comments still needing to be addressed and the tests failing this now looks good |
alessioventuriniAND
deleted the
2835/bug/ons-grid__col-sticky-css-functionality-is-broken
branch
What is the context of this PR?
Fixes: #2835
Previously, the ons grid had the functionality to make columns sticky i.e. have the object have fixed positioning on the screen. This worked when the grid was not contained within any page however was broken when the class was applied to an object within a full page such as the base page template. The change fixes this to work within the full page and adds an additional visual regression test for testing the sticky class in full pages
Additional documentation about this class is also needed and the new VR example can be used for demonstration see ticket: #2969
How to review this PR
Describe the steps required to test the changes (include screenshots if appropriate).
Navigate to the new regression test within the table component and check that the contents section on the page remains in place whilst scrolling.
Checklist
This needs to be completed by the person raising the PR.