Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid sticky functionality fixed in full pages #2960

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
793533f
Fix issue and add test
adi-unni Nov 20, 2023
a2b1a98
Update VR images
adi-unni Nov 21, 2023
c470473
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
adi-unni Nov 23, 2023
7563cef
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
adi-unni Dec 1, 2023
42d4bf8
Update reference images
adi-unni Dec 1, 2023
9e40abe
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
alessioventuriniAND Dec 4, 2023
46d5435
Add test skeleton
adi-unni Dec 7, 2023
51e6edb
Add imports
adi-unni Dec 7, 2023
c996a86
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
alessioventuriniAND Dec 7, 2023
6025f83
tried different approach to test
alessioventuriniAND Dec 8, 2023
2ac815a
Update Tests
adi-unni Dec 8, 2023
30ad545
Remove mistaken title
adi-unni Dec 8, 2023
ed1e311
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
alessioventuriniAND Dec 8, 2023
47c74bc
Fix errors
adi-unni Dec 11, 2023
4c8b462
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
adi-unni Dec 11, 2023
97e7e9d
Update VR test
adi-unni Dec 11, 2023
9d9a108
Update test names
adi-unni Dec 11, 2023
3379372
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
alessioventuriniAND Dec 11, 2023
524d10e
Merge branch 'main' into 2835/bug/ons-grid__col-sticky-css-functional…
alessioventuriniAND Dec 12, 2023
1165f39
updated vr and merged main in
alessioventuriniAND Dec 12, 2023
af7b3d4
updated references vr
alessioventuriniAND Dec 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ layout: ~
"itemsList": [
{
"url": '#section1',
"text": 'What is the benson?'
"text": 'What is the census?'
},
{
"url": '#section2',
Expand Down
2 changes: 1 addition & 1 deletion src/components/table-of-contents/toc.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ describe('script: table-of-contents-fixed-position', () => {
);
});

it('renders a fixed table of contents in full page and scrolls', async () => {
it('when ons-grid__col--stick is used, ToC stays fixed while scrolling', async () => {
alessioventuriniAND marked this conversation as resolved.
Show resolved Hide resolved
await page.evaluate(() => {
window.scrollTo(0, 1000);
});
Expand Down
Loading