Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stacker): Motor timer bringup #454

Merged
merged 14 commits into from
Aug 13, 2024
Merged

feat(stacker): Motor timer bringup #454

merged 14 commits into from
Aug 13, 2024

Conversation

ahiuchingau
Copy link
Contributor

Bringing up the motor timers for XLZ axes with them ticking at 100KHz.

@ahiuchingau ahiuchingau marked this pull request as ready for review August 8, 2024 19:57
Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once we fix the linter stuff

@@ -12,4 +12,7 @@ void ui_hardware_set_heartbeat_led(bool setting) {
//NOLINTNEXTLINE(performance-no-int-to-ptr)
HAL_GPIO_WritePin(nSTATUS_LED_GPIO_Port, nSTATUS_LED_Pin,
setting ? GPIO_PIN_SET : GPIO_PIN_RESET);

// HAL_GPIO_WritePin(GPIOC, GPIO_PIN_2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused code

@vegano1
Copy link
Contributor

vegano1 commented Aug 13, 2024

Looks good,
Lets get the lint tests to pass and we should be good to go.

@ahiuchingau ahiuchingau merged commit 2a06ed3 into edge Aug 13, 2024
6 of 7 checks passed
@ahiuchingau ahiuchingau deleted the motor-timer-bringup branch August 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants