Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incompatible-mods.json #256

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Update incompatible-mods.json #256

merged 3 commits into from
Nov 22, 2024

Conversation

maloryware
Copy link
Contributor

@maloryware maloryware commented Nov 17, 2024

Added note for Requiem (1.19.2), and Progressive Archery


See preview on Cloudflare Pages: https://preview-256.quiltmc-org.pages.dev

Added note for Requiem (1.19.2), and Progressive Archery
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

"name": "Progressive Archery",
"type": "GAME",
"status": "UNKNOWN",
"tracking": "UNKNOWN",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind making an issue here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; I'd rather test it manually beforehand, though.

public/api/v1/incompatible-mods.json Show resolved Hide resolved
"status": "UNKNOWN",
"tracking": "UNKNOWN",
"icon": "https://cdn.modrinth.com/data/QgHW53j5/590f3d5c405da0ffe21dd6fb12d2360d382531e7.png"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any details about the error that you could add in a note? Even just the top-level exception that it prints would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon testing, it seems that the mod doesn't break the launcher by itself - it's possibly an incompatibility with another commonly used mod. I'll wait until more crash reports where this mod is involved to show up before making any further changes to the incompatibility listing. If warranted, can be removed altogether until then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd definitely want to wait before adding it, in that case. Is it known whether the crash is Quilt-specific? If not, it shouldn't go on the list at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the block for Progressive Archery so that the PR can be reviewed and hopefully merged. If issues with Progressive Archery arise in the future, I'll take a closer look and properly detail the problem with the mod in another PR.

@maloryware maloryware changed the base branch from main to incompatible-mods-update November 22, 2024 04:12
@maloryware maloryware changed the base branch from incompatible-mods-update to main November 22, 2024 04:12
@maloryware
Copy link
Contributor Author

Ignore that. Fat fingered the 'save' button on mobile while looking through options.

@ix0rai ix0rai merged commit d92584a into QuiltMC:main Nov 22, 2024
@maloryware maloryware deleted the patch-1 branch November 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants