-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incompatible-mods.json #256
Conversation
Added note for Requiem (1.19.2), and Progressive Archery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
public/api/v1/incompatible-mods.json
Outdated
"name": "Progressive Archery", | ||
"type": "GAME", | ||
"status": "UNKNOWN", | ||
"tracking": "UNKNOWN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind making an issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure; I'd rather test it manually beforehand, though.
"status": "UNKNOWN", | ||
"tracking": "UNKNOWN", | ||
"icon": "https://cdn.modrinth.com/data/QgHW53j5/590f3d5c405da0ffe21dd6fb12d2360d382531e7.png" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any details about the error that you could add in a note? Even just the top-level exception that it prints would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon testing, it seems that the mod doesn't break the launcher by itself - it's possibly an incompatibility with another commonly used mod. I'll wait until more crash reports where this mod is involved to show up before making any further changes to the incompatibility listing. If warranted, can be removed altogether until then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd definitely want to wait before adding it, in that case. Is it known whether the crash is Quilt-specific? If not, it shouldn't go on the list at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove the block for Progressive Archery so that the PR can be reviewed and hopefully merged. If issues with Progressive Archery arise in the future, I'll take a closer look and properly detail the problem with the mod in another PR.
Co-authored-by: Southpaw <[email protected]>
Ignore that. Fat fingered the 'save' button on mobile while looking through options. |
Added note for Requiem (1.19.2), and Progressive Archery
See preview on Cloudflare Pages: https://preview-256.quiltmc-org.pages.dev