Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incompatible-mods.json #256

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Update incompatible-mods.json #256

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e410ad
Update incompatible-mods.json
maloryware Nov 17, 2024
e9ac0e6
Refactored the note for accuracy
maloryware Nov 18, 2024
426cb25
Removed 'Progressive Archery' entry due to lack of information
maloryware Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion public/api/v1/incompatible-mods.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,22 @@
"tracking": "UNKNOWN",
"note": "Compostable items cannot be composted on Quilt",
"icon": "https://cdn.modrinth.com/data/HJetCzWo/baf9ea57b7784e743aa33441105723205d743351.png"
}
},
{
"ids": ["requiem"],
"name": "Requiem",
"type": "WORKAROUND",
"status": "WONT_FIX",
ix0rai marked this conversation as resolved.
Show resolved Hide resolved
"tracking": "https://github.com/Ladysnake/Requiem/issues/670",
"note": "Requires a specific version of Quilt Standard Libraries on 1.19.2: https://modrinth.com/mod/qsl/version/4.0.0-beta.30+0.76.0-1.19.2",
maloryware marked this conversation as resolved.
Show resolved Hide resolved
"icon": "https://cdn.modrinth.com/data/bYmqMxlQ/41b48c13bc4acd691dccc93b09c97995f0509880_96.webp"
},
{
"ids": ["progressive-archery"],
"name": "Progressive Archery",
"type": "GAME",
"status": "UNKNOWN",
"tracking": "UNKNOWN",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind making an issue here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; I'd rather test it manually beforehand, though.

"icon": "https://cdn.modrinth.com/data/QgHW53j5/590f3d5c405da0ffe21dd6fb12d2360d382531e7.png"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any details about the error that you could add in a note? Even just the top-level exception that it prints would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon testing, it seems that the mod doesn't break the launcher by itself - it's possibly an incompatibility with another commonly used mod. I'll wait until more crash reports where this mod is involved to show up before making any further changes to the incompatibility listing. If warranted, can be removed altogether until then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd definitely want to wait before adding it, in that case. Is it known whether the crash is Quilt-specific? If not, it shouldn't go on the list at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the block for Progressive Archery so that the PR can be reviewed and hopefully merged. If issues with Progressive Archery arise in the future, I'll take a closer look and properly detail the problem with the mod in another PR.

]
Loading