Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm installation of phantomJS from R CMD check and test coverage gh actions #377

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jacobvjk
Copy link
Member

@jacobvjk jacobvjk commented Jan 8, 2025

closes #376

@jacobvjk jacobvjk requested review from cjyetman and jdhoffa January 8, 2025 08:35
Copy link

github-actions bot commented Jan 8, 2025

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-08 09:48 UTC

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (d1b3a22) to head (f684911).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   80.05%   79.97%   -0.09%     
==========================================
  Files          29       29              
  Lines        3269     3186      -83     
==========================================
- Hits         2617     2548      -69     
+ Misses        652      638      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobvjk jacobvjk merged commit 618e1fb into main Jan 8, 2025
12 checks passed
@jacobvjk jacobvjk deleted the rm-phantomJS-from-gh-action branch January 8, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not try to install phantomJS in R CMD action
2 participants