Include SCRIPT_ROOT in URL creattion w JS #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkc
reviewed
Oct 16, 2023
| @@ -42,7 +43,8 @@ | |||
| const body = { | |||
| remove_all: true | |||
| } | |||
| fetch(`${window.origin}/api/basket/remove`, { | |||
| const baseUrl = {{ request.script_root|tojson }} | |||
| fetch(`${baseUrl}/api/basket/remove`, { | |||
There was a problem hiding this comment.
good thing we put the actual api at lennart:80/bonsai/api/v1 rather than just lennart:80/bonsai/api/, otherwise all client api calls like this one would be directed by apache to the actual api.
alkc
approved these changes
Oct 16, 2023
|
I've also confirmed that the code does not break dev instances of bonsai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with resolving valid URLs if Bonsai is hosted in a subpath.
Close #74