Conversation
Contributor
♿ Accessibility audit — WCAG 2.2 AA⏭️ 37 story(ies) safe to skip in manual review — color-contrast only
@surfnet/curve-angular — 90 finding(s)Alert — 6 finding(s) · color-contrast only
Badge — 3 finding(s) · color-contrast onlyButton — 4 finding(s) · color-contrast onlyCalendar — 56 finding(s) · color-contrast only
DataTable — 1 finding(s) · color-contrast onlyEmpty — 2 finding(s) · color-contrast onlyItem — 1 finding(s) · color-contrast onlyPagination — 14 finding(s) · color-contrast only
Sidebar — 2 finding(s) · color-contrast only@surfnet/curve-react — 24 finding(s)Alert — 6 finding(s) · color-contrast only
Badge — 3 finding(s) · color-contrast onlyButton — 4 finding(s) · color-contrast onlyCalendar — 3 finding(s) · color-contrast onlyCard — 1 finding(s) · color-contrast onlyDataTable — 1 finding(s) · color-contrast onlyEmpty — 2 finding(s) · color-contrast onlyItem — 1 finding(s) · color-contrast onlySidebar — 2 finding(s) · color-contrast onlyAutomated axe covers ~30–50% of WCAG 2.2 AA. Keyboard, screen-reader and reflow checks still need a manual pass. Full per-story JSON is in the run’s |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















































































































Summary
After talking to a developer for MORIS, it was pointed out that in the Angular code examples, there is a lot of use of brackets for attributes that don't need logic settings (like button variants, sizes).
Related issue
N/A
Type of change
Checklist
pnpm build,pnpm lint, andpnpm formatpasspnpm changeset) — required for any change to@surfnet/curve-reactor@surfnet/curve-angular; N/A for docs/CI-only changes@surfnet/curve-contracts)