Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config updated: Working per server/library scheduling with ofelia #2142

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

SebbeJohansson
Copy link
Contributor

@SebbeJohansson SebbeJohansson commented Jan 7, 2025

  • Removes "schedule" profile in multi server setup since it doesnt work.
  • Updates image versions so that it is cohesive through the whole documentation (latest on all).
  • Updates config volume path so that it is the same in multi server config as it is in the single server config.

After discussions and testing for #2139.

@simonc56
Copy link
Collaborator

simonc56 commented Jan 8, 2025

We have no prove that "schedule" profile does not work, I suggest you edit this line in first post.
I agree to remove the profile: "schedule" stuff which is not needed and misleading users unable to read the doc.

@SebbeJohansson
Copy link
Contributor Author

@simonc56 The proof would be in that it doesn't work anymore on a clean system. Feel free to test it yourself.

README.md Outdated
@@ -124,7 +124,7 @@ You can setup docker compose file like this:
version: "2"
services:
plextraktsync:
image: ghcr.io/taxel/plextraktsync
image: ghcr.io/taxel/plextraktsync:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this chunk

README.md Outdated
@@ -452,12 +452,11 @@ something similar to this in your `docker-compose.yml`:
```yml
services:
plextraktsync:
image: ghcr.io/taxel/plextraktsync
image: ghcr.io/taxel/plextraktsync:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this chunk

@glensc
Copy link
Collaborator

glensc commented Jan 8, 2025

Ideally, I'd see one change per pull request. lower chances that unrelated changes don't block whole pr merge. you made three changes, one of them is rejected. also improves one change per commit one, of your commit changes two different things.

@SebbeJohansson
Copy link
Contributor Author

@glensc Just to be clear, you are against adding ":latest" to the places where it is missing? Should we remove it from all places? I can revert the chunks here and make a new pr for how ever you want it.

@glensc
Copy link
Collaborator

glensc commented Jan 8, 2025

@SebbeJohansson I'm against using places you filled it, for ofelia I already said add major version rather latest.

@SebbeJohansson
Copy link
Contributor Author

@glensc okay so the documentation should have different images for different parts. Im not sure I'm a fan of that, but I'm not gonna fight it.

I have reverted the chunks you specified and added versions to the ofelia image.

@glensc
Copy link
Collaborator

glensc commented Jan 9, 2025

@SebbeJohansson, as I said, ofelia should be pinned to some major version. so if they release something breaking, the docs here would still be acurate. As for plextraktsync, it's current repository, it's latest will be supported, rather than any other major.

aside, plextraktsync is still in initial development: 0.x :)

@glensc glensc merged commit e82b324 into Taxel:main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants