Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trakt from git repository #984

Merged
merged 4 commits into from
Oct 23, 2022
Merged

Use trakt from git repository #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2c9620
Use trakt from git repository
glensc Jul 23, 2022
b8afd9c
Try installing from zip url
glensc Oct 23, 2022
22b0f26
Use trakt@ marker
glensc Oct 23, 2022
a28fa88
Add trakt dependency update instructions
glensc Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ pipenv run plextraktsync

[pipenv]: https://pipenv.pypa.io/

## Updating trakt dependency

1. Update version in `trakt/__init__py`, commit, push it
1. Add git tag, push it
1. Run `pipenv install "trakt@https://github.com/glensc/python-trakt/archive/refs/tags/3.4.1.zip#egg=trakt"`
1. Update trakt version manually in `requirements.txt`, `pipenv lock --requirements` loses the `trakt@` prefix

## Testing

We use [pytest] for testing.
Expand Down
2 changes: 1 addition & 1 deletion Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ requests = ">=2.25.1"
requests-cache = "==0.9.6"
rich = "==12.6.0"
tqdm = "==4.64.1"
trakt = "==3.4.0"
urllib3 = ">=1.26.6"
websocket-client = "==1.4.1"
trakt = {file = "https://github.com/glensc/python-trakt/archive/refs/tags/3.4.0.zip"}

[requires]
python_version = "3"
Expand Down
8 changes: 2 additions & 6 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ click==8.1.3
commonmark==0.9.1
deprecated==1.2.13
exceptiongroup==1.0.0rc9; python_version < '3.11'
trakt @ https://github.com/glensc/python-trakt/archive/refs/tags/3.4.0.zip#egg=trakt
idna==3.4; python_version >= '3.5'
inquirerpy==0.3.4
oauthlib==3.2.2; python_version >= '3.6'
Expand All @@ -31,7 +32,6 @@ requests==2.28.1
rich==12.6.0
six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
tqdm==4.64.1
trakt==3.4.0
url-normalize==1.4.3; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'
urllib3==1.26.12
wcwidth==0.2.5
Expand Down