Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trakt from git repository #984

Merged
merged 4 commits into from
Oct 23, 2022
Merged

Use trakt from git repository #984

merged 4 commits into from
Oct 23, 2022

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Jul 23, 2022

Testing to use trakt as git repository because current trakt maintainer is unavailable:

Test for:

uses repo from:

commands:

pipenv install "git+https://github.com/glensc/[email protected]#egg=trakt"
pipenv lock --requirements > requirements.txt

@glensc glensc self-assigned this Jul 23, 2022
@glensc glensc mentioned this pull request Aug 2, 2022
@glensc
Copy link
Collaborator Author

glensc commented Aug 4, 2022

pipx install works at least:

 $ plextraktsync self-update --pr 984
Updating PlexTraktSync to the pull request #984 version using pipx
  installed package PlexTraktSync 0.20.0.dev0 (PlexTraktSync@984), installed using Python 3.10.5
  These apps are now globally available
    - plextraktsync@984
done! ✨ 🌟 ✨

@glensc
Copy link
Collaborator Author

glensc commented Aug 4, 2022

these seem to work too:

pip install -r requirements.txt
pipenv install

but I hacked (0a6459e) Pipfile.lock to use ref: 3.4.0 rather commit hash

@glensc
Copy link
Collaborator Author

glensc commented Aug 4, 2022

the pipx install was invalid, i didn't had updated requirements.txt, but now with updated requirements (b9b3e38) I get parse error:

@glensc
Copy link
Collaborator Author

glensc commented Oct 11, 2022

@glensc glensc force-pushed the git-trakt branch 2 times, most recently from e7aa1b4 to ed5272b Compare October 23, 2022 12:31
@glensc glensc marked this pull request as ready for review October 23, 2022 12:51
@glensc
Copy link
Collaborator Author

glensc commented Oct 23, 2022

Seems to work.

  1. install from pr: plextraktsync self-update --pr=984
  2. docker image is also published ghcr.io/glensc/plex-trakt-sync:git-trakt

but updating dependency in the future involves some manual work, as pipenv doesn't support this:

so, added docs to contributing file how to update: ab24564

@glensc
Copy link
Collaborator Author

glensc commented Oct 23, 2022

Lets roll then!

@glensc glensc merged commit a40930e into Taxel:main Oct 23, 2022
@glensc glensc deleted the git-trakt branch October 23, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant