Return problem detail when LCP fulfillment fails (PP-1641) #2033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If LCP fulfillment request does not return a status in the 2xx range, raise a
ProblemDetailException
, which will be returned to the clients.Motivation and Context
We've seen a number of times recently when LCP fulfillment fails, and the CM just blindly passes along whatever the LCP API gives us, which confuses the apps. Instead in this PR if we get an unexpected status code, we turn that into a problem detail, and log the issue. This should give a better user experience and let us track down the problems from our logs.
This PR is only a couple lines, but it took a lot of refactoring in #2034 and #2035 to get here.
How Has This Been Tested?
Checklist