Refactor BadResponseException (PP-1641) #2034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
BadResponseException
, so it has a reference to the response that can be used to deal with the exception.This required changing a couple references to
RemoteIntegrationException
, where the response wasn't readily available. These exceptions have the same base class, so this should be handled okay.I updated the OPDS2 + ODL importer to use the new exception, rather then doing its own status code parsing. I also updated mock OPDS2 + ODL importer to use
MockHTTPClient
instead of having its own mock client.Motivation and Context
How Has This Been Tested?
Checklist