Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unncessary Symbols #2049

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Remove Unncessary Symbols #2049

merged 1 commit into from
Jan 10, 2025

Conversation

hohle
Copy link
Contributor

@hohle hohle commented Jan 9, 2025

Cleans up symbols that are now determined at compile or link time and no longer references from ASM.

@Xeeynamo
Copy link
Owner

Xeeynamo commented Jan 9, 2025

I am not at home to verify this. But you might need to add g_ServantDesc to the undefined symbol list in config/ as the linker needs to resolve its address

@hohle hohle force-pushed the symbol-cleanup branch 2 times, most recently from 82f1a81 to ece6d78 Compare January 9, 2025 18:44
@hohle
Copy link
Contributor Author

hohle commented Jan 9, 2025

I got a little ahead of myself on the first push. The format of symbols.$VERSION.$OVERLAY.txt seems to need to be compatible with both splat and ld, but ld doesn't like modern single line comments.

Moving the symbols to the undefined_syms file worked out and may be a great place for overlay boundary symbols.

Copy link
Owner

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved, but it looks good to me!

Cleans up symbols that are now determined at compile or link time and no
longer references from ASM.
@sozud sozud merged commit cf37fe0 into Xeeynamo:master Jan 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants