Repository navigation
Update @abaplint/cli to 2.120.75 and copy the shared app rule set's eleven new rules - #97
Merged
Merged
Conversation
…leven new rules abaplint 2.120.75 adds eleven rules. abap2UI5's app-rules.json names them (same change set there), and this block copies it: ten on with 0 findings in samples, samples-controls, samples-stack and protocol's conformance apps (abapdoc_html_tag, abapdoc_leading_at, abapdoc_parameter_names, changing_sorted_line, delete_index_in_loop, final_newline, inline_packed_computation, range_row_values, sort_empty_key, subrc_after_assign), prefer_inline_cast off with its reason (2 / 0 / 0, a style rewrite of the cast of the previous app a sample reads back). 212 rules named, 190 on, 22 off. scripts/check-app-rules.mjs is the abap2UI5 source copied byte-equal (its count says 211). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Merged
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinated set - merge together with abap2UI5/abap2UI5#2899 (the source,
app-rules.json), abap2UI5/samples, abap2UI5/samples-controls and abap2UI5/protocol (same title).check-app-rulescompares this block with abap2UI5'smain, so it is red until #2899 is merged (and abap2UI5'scheck:sharedis red until this one is).@abaplint/cli^2.120.73 -> ^2.120.75 (CONVENTIONS.md §4), lockfile by npm.abapdoc_html_tag,abapdoc_leading_at,abapdoc_parameter_names,changing_sorted_line,delete_index_in_loop,final_newline,inline_packed_computation,range_row_values,sort_empty_key,subrc_after_assignprefer_inline_cast(2 / 0 / 0, all in samples) - a style rewrite. Reason in a comment above it.scripts/check-app-rules.mjsis abap2UI5's shared source copied byte-equal (count 211).Checked locally:
npm run checkgreen (lint 0 issues;check:app-rulesagainst the abap2UI5 branch OK).Note, not changed: abap2UI5's abap-check skill still says this repository runs its own
check:abapdoc"until its abaplint pin moves" - the pin moved long ago (2.120.51+); whether that script can go now thatwrong_abapdoc_positionalso reports the blank-line and comment shapes (2.120.75) is a separate decision.The badge-workflow permission change is a separate PR (branch
claude/beautiful-turing-wxr303-badges), independent of this one.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code